Merge lp:~3v1n0/bamf/libbamf-matcher-dispose into lp:bamf/0.4
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Michal Hruby |
Approved revision: | 459 |
Merged at revision: | 459 |
Proposed branch: | lp:~3v1n0/bamf/libbamf-matcher-dispose |
Merge into: | lp:bamf/0.4 |
Diff against target: |
80 lines (+52/-1) 1 file modified
lib/libbamf/bamf-matcher.c (+52/-1) |
To merge this branch: | bzr merge lp:~3v1n0/bamf/libbamf-matcher-dispose |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+103294@code.launchpad.net |
Commit message
libbamf, BamfMatcher: added finalize and dispose functions to disconnect to proxy when destructed
Description of the change
libbamf matcher proxy was never destroyed and its signals disconnected when the matcher was destructed (even if it's designed to use a singleton, it could happen).
This should be somewhat related to this: http://
To post a comment you must log in.
Looks fine, it's pretty strange that bamf_matcher_ get_default returns an owned reference, but it has its benefits.